Fix slow Process table #463
Draft
+47
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid keeping process info for all processes in memory - avoid .sort, .take, and .map on extremely long lists - remains fast for hundreds of thousands of processes - only slow (3s) showing 5000 processes out of hundreds of thousands
|
Thank you for the PR @sbothma! Can you please look into failing tests? I also wonder if we should add |
|
This is still hitting a bottleneck somewhere around 200 000 processes. I'll split out the take_sort implementation. My goal here is to be able to have the Process table respond in less than a second (the minimum auto update rate). At least up to the default process limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Process table is unusable when the node is running many processes.